From: Florian Müllner Date: Mon, 16 Dec 2019 23:21:46 +0000 (+0100) Subject: networkAgent: Handle 'vpn' connections when delaying request X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~781^2^2~254 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=1ef4d85b50de5585909a5d5f4457ebccb37cea91;p=gnome-shell.git networkAgent: Handle 'vpn' connections when delaying request Since commit 90a08ba0b6a, we only open a network secret dialog immediately in response to user action, and show a notification otherwise. While for the actual request VPNs are handled separately from other connections, this isn't true when we show the notification - we need to handle 'vpn' together with the other types there, or we fall through to the default 'invalid type' exception. https://gitlab.gnome.org/GNOME/gnome-shell/issues/2008 --- diff --git a/js/ui/components/networkAgent.js b/js/ui/components/networkAgent.js index ee376326b..6779b3147 100644 --- a/js/ui/components/networkAgent.js +++ b/js/ui/components/networkAgent.js @@ -725,6 +725,10 @@ var NetworkAgent = class { title = _("Mobile broadband network password"); body = _("A password is required to connect to “%s”.").format(connectionSetting.get_id()); break; + case 'vpn': + title = _("VPN password"); + body = _("A password is required to connect to “%s”.").format(connectionSetting.get_id()); + break; default: log(`Invalid connection type: ${connectionType}`); this._native.respond(requestId, Shell.NetworkAgentResponse.INTERNAL_ERROR);